Add fail2ban role and clean up yaml lint noise

roles/ensure_os_upgrade/tasks/main.yml

@@ -1,35 +1,37 @@
 ---
 # tasks file for ensure_os_upgrade
-- name: 'include variables'
-  when:
-    - ansible_facts["system"] == 'Linux'
+- name: include variables
+  when: ["ansible_facts[\"system\"] == 'Linux'"]
   ansible.builtin.include_vars:
     file: '{{ lookup("first_found", findme) }}'
-    name: 'ensure_os_upgrade'
+    name: ensure_os_upgrade
   vars:
     findme:
       files:
-        - '{{ ansible_facts["distribution"] }}-{{ ansible_facts["distribution_major_version"] }}-{{ ansible_facts["architecture"] }}.yml'
-        - '{{ ansible_facts["distribution"] }}-{{ ansible_facts["distribution_major_version"] }}-default.yml'
+        - '{{ ansible_facts["distribution"] }}-{{ ansible_facts["distribution_major_version"]
+          }}-{{ ansible_facts["architecture"] }}.yml'
+        - '{{ ansible_facts["distribution"] }}-{{ ansible_facts["distribution_major_version"]
+          }}-default.yml'
         - '{{ ansible_facts["distribution"] }}-default.yml'
-        - '{{ ansible_facts["os_family"] }}-{{ ansible_facts["distribution_major_version"] }}-{{ ansible_facts["architecture"] }}.yml'
-        - '{{ ansible_facts["os_family"] }}-{{ ansible_facts["distribution_major_version"] }}-default.yml'
+        - '{{ ansible_facts["os_family"] }}-{{ ansible_facts["distribution_major_version"]
+          }}-{{ ansible_facts["architecture"] }}.yml'
+        - '{{ ansible_facts["os_family"] }}-{{ ansible_facts["distribution_major_version"]
+          }}-default.yml'
         - '{{ ansible_facts["os_family"] }}-default.yml'
-        - 'default.yml'
-      paths:
-        - '../vars/'
-      errors: 'ignore'
-- name: 'package discovery'
+        - default.yml
+      paths: [../vars/]
+      errors: ignore
+- name: package discovery
   when:
     - ansible_facts["system"] == 'Linux'
     - ansible_facts["packages"] is not defined
   ansible.builtin.package_facts:
-- name: 'service discovery'
+- name: service discovery
   when:
     - ansible_facts["system"] == 'Linux'
     - ansible_facts["services"] is not defined
   ansible.builtin.service_facts:
-- name: 'ensure packages'
+- name: ensure packages
   when:
     - ansible_facts["system"] == 'Linux'
     - ensure_os_upgrade is defined
@@ -42,9 +44,9 @@
   loop_control:
     label: '{{ item.name }} will be {{ item.state }}'
   notify:
-    - 'ensure_os_upgrade.package_facts'
-    - 'ensure_os_upgrade.service_facts'
-- name: 'ensure services'
+    - ensure_os_upgrade.package_facts
+    - ensure_os_upgrade.service_facts
+- name: ensure services
   when:
     - ansible_facts["system"] == 'Linux'
     - ensure_os_upgrade is defined
@@ -58,9 +60,9 @@
   loop_control:
     label: '{{ item.name }} will be {{ item.state }}'
   notify:
-    - 'ensure_os_upgrade.package_facts'
-    - 'ensure_os_upgrade.service_facts'
-- name: 'Ensure system-upgrade download'
+    - ensure_os_upgrade.package_facts
+    - ensure_os_upgrade.service_facts
+- name: Ensure system-upgrade download
   when:
     - ansible_facts["system"] == 'Linux'
     - ansible_facts["distribution"] == 'Fedora'
@@ -71,7 +73,7 @@
     - ansible_facts["distribution_major_version"]|int < ensure_os_upgrade.target_version|int
   ansible.builtin.shell: >
     dnf -y system-upgrade download --refresh --releasever={{ ensure_os_upgrade.target_version|int }}
-- name: 'Ensure system-upgrade reboot'
+- name: Ensure system-upgrade reboot
   when:
     - ansible_facts["system"] == 'Linux'
     - ansible_facts["distribution"] == 'Fedora'
@@ -84,7 +86,7 @@
   poll: 0
   ansible.builtin.shell: >
     sleep 5 && dnf -y system-upgrade reboot
-- name: 'Wait for the reboot'
+- name: Wait for the reboot
   when:
     - ansible_facts["system"] == 'Linux'
     - ansible_facts["distribution"] == 'Fedora'
@@ -98,16 +100,15 @@
     delay: '300'
     host: '{{ (ansible_ssh_host|default(ansible_host))|default(inventory_hostname) }}'
     port: '22'
-    search_regex: 'OpenSSH'
+    search_regex: OpenSSH
     sleep: '15'
     timeout: '1800'
   vars:
-    ansible_connection: 'local'
-- name: 'Gather facts'
+    ansible_connection: local
+- name: Gather facts
   ansible.builtin.setup:
   notify:
-    - 'ensure_os_upgrade.package_facts'
-    - 'ensure_os_upgrade.service_facts'
-- name: 'flush handlers'
-  ansible.builtin.meta: 'flush_handlers'
-...
+    - ensure_os_upgrade.package_facts
+    - ensure_os_upgrade.service_facts
+- name: flush handlers
+  ansible.builtin.meta: flush_handlers