Add fail2ban role and clean up yaml lint noise

roles/ensure_rsync/tasks/main.yml

@@ -1,35 +1,37 @@
 ---
 # tasks file for ensure_rsync
-- name: 'include variables'
-  when:
-    - ansible_facts["system"] == 'Linux'
+- name: include variables
+  when: ["ansible_facts[\"system\"] == 'Linux'"]
   ansible.builtin.include_vars:
     file: '{{ lookup("first_found", findme) }}'
-    name: 'ensure_rsync'
+    name: ensure_rsync
   vars:
     findme:
       files:
-        - '{{ ansible_facts["distribution"] }}-{{ ansible_facts["distribution_major_version"] }}-{{ ansible_facts["architecture"] }}.yml'
-        - '{{ ansible_facts["distribution"] }}-{{ ansible_facts["distribution_major_version"] }}-default.yml'
+        - '{{ ansible_facts["distribution"] }}-{{ ansible_facts["distribution_major_version"]
+          }}-{{ ansible_facts["architecture"] }}.yml'
+        - '{{ ansible_facts["distribution"] }}-{{ ansible_facts["distribution_major_version"]
+          }}-default.yml'
         - '{{ ansible_facts["distribution"] }}-default.yml'
-        - '{{ ansible_facts["os_family"] }}-{{ ansible_facts["distribution_major_version"] }}-{{ ansible_facts["architecture"] }}.yml'
-        - '{{ ansible_facts["os_family"] }}-{{ ansible_facts["distribution_major_version"] }}-default.yml'
+        - '{{ ansible_facts["os_family"] }}-{{ ansible_facts["distribution_major_version"]
+          }}-{{ ansible_facts["architecture"] }}.yml'
+        - '{{ ansible_facts["os_family"] }}-{{ ansible_facts["distribution_major_version"]
+          }}-default.yml'
         - '{{ ansible_facts["os_family"] }}-default.yml'
-        - 'default.yml'
-      paths:
-        - '../vars/'
-      errors: 'ignore'
-- name: 'package discovery'
+        - default.yml
+      paths: [../vars/]
+      errors: ignore
+- name: package discovery
   when:
     - ansible_facts["system"] == 'Linux'
     - ansible_facts["packages"] is not defined
   ansible.builtin.package_facts:
-- name: 'service discovery'
+- name: service discovery
   when:
     - ansible_facts["system"] == 'Linux'
     - ansible_facts["services"] is not defined
   ansible.builtin.service_facts:
-- name: 'ensure packages'
+- name: ensure packages
   when:
     - ansible_facts["system"] == 'Linux'
     - ensure_rsync is defined
@@ -41,10 +43,8 @@
   loop: '{{ ensure_rsync.package_list }}'
   loop_control:
     label: '{{ item.name }} will be {{ item.state }}'
-  notify:
-    - 'ensure_rsync.package_facts'
-    - 'ensure_rsync.service_facts'
-- name: 'ensure configurations'
+  notify: [ensure_rsync.package_facts, ensure_rsync.service_facts]
+- name: ensure configurations
   when:
     - ansible_facts["system"] == 'Linux'
     - ensure_rsync is defined
@@ -65,11 +65,11 @@
   loop_control:
     label: '{{ item.dest }} will be ensured'
   notify:
-    - 'ensure_rsync.package_facts'
-    - 'ensure_rsync.service_facts'
-    - 'ensure_rsync.service_reload'
-    - 'ensure_rsync.service_restart'
-- name: 'ensure services'
+    - ensure_rsync.package_facts
+    - ensure_rsync.service_facts
+    - ensure_rsync.service_reload
+    - ensure_rsync.service_restart
+- name: ensure services
   when:
     - ansible_facts["system"] == 'Linux'
     - ensure_rsync is defined
@@ -82,10 +82,8 @@
   loop: '{{ ensure_rsync.service_list }}'
   loop_control:
     label: '{{ item.name }} will be {{ item.state }}'
-  notify:
-    - 'ensure_rsync.package_facts'
-    - 'ensure_rsync.service_facts'
-- name: 'Ensure SELinux is configured'
+  notify: [ensure_rsync.package_facts, ensure_rsync.service_facts]
+- name: Ensure SELinux is configured
   when:
     - ansible_facts["system"] == 'Linux'
     - ensure_rsync is defined
@@ -94,23 +92,23 @@
   ansible.posix.selinux:
     policy: '{{ ensure_rsync.selinux_policy }}'
     state: '{{ ensure_rsync.selinux_state }}'
-  register: 'ensure_rsync_results'
+  register: ensure_rsync_results
   notify:
-    - 'ensure_rsync.package_facts'
-    - 'ensure_rsync.service_facts'
-    - 'ensure_rsync.service_reload'
-    - 'ensure_rsync.service_restart'
-- name: 'Reboot if required'
+    - ensure_rsync.package_facts
+    - ensure_rsync.service_facts
+    - ensure_rsync.service_reload
+    - ensure_rsync.service_restart
+- name: Reboot if required
   when:
     - ansible_facts["system"] == 'Linux'
     - ensure_rsync is defined
     - ensure_rsync.selinux_policy is defined
-    - ensure_rsync.selinux_state is defined # This line is correct, no change needed
+    - ensure_rsync.selinux_state is defined  # This line is correct, no change needed
     - ensure_rsync_results is defined
     - ensure_rsync_results.reboot_required is defined
     - ensure_rsync_results.reboot_required
   ansible.builtin.reboot:
-- name: 'ensure seboolean'
+- name: ensure seboolean
   when:
     - ansible_facts["system"] == 'Linux'
     - ensure_rsync is defined
@@ -124,10 +122,9 @@
   loop_control:
     label: '{{ item.name }} will be {{ item.state }}'
   notify:
-    - 'ensure_rsync.package_facts'
-    - 'ensure_rsync.service_facts'
-    - 'ensure_rsync.service_reload'
-    - 'ensure_rsync.service_restart'
-- name: 'flush handlers'
-  ansible.builtin.meta: 'flush_handlers'
-...
+    - ensure_rsync.package_facts
+    - ensure_rsync.service_facts
+    - ensure_rsync.service_reload
+    - ensure_rsync.service_restart
+- name: flush handlers
+  ansible.builtin.meta: flush_handlers